Fix warning when using xcomarg dependencies #26801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was invisible before 2.4 due to a bug in our logging config (fixed by commit 7363e35) and AIP-45 which suddenly made this appear. The problem was being caused by set_xcomargs_dependencies being called once for each class in the hierarchy, and each of them doing the same logic. The fix is to look at the _actual_ function of `self.__init__` and compare it to the function we're about to call so that we don't set dependencies until we have finished the "outer" most class's apply_defaults invocation.
ephraimbuddy
approved these changes
Sep 30, 2022
norm
approved these changes
Sep 30, 2022
jedcunningham
approved these changes
Sep 30, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
This warning was invisible before 2.4 due to a bug in our logging config (fixed by commit 7363e35) and AIP-45 which suddenly made this appear. The problem was being caused by set_xcomargs_dependencies being called once for each class in the hierarchy, and each of them doing the same logic. The fix is to look at the _actual_ function of `self.__init__` and compare it to the function we're about to call so that we don't set dependencies until we have finished the "outer" most class's apply_defaults invocation. (cherry picked from commit d77f056)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was invisible before 2.4 due to a bug in our logging config (fixed by commit 7363e35) and AIP-45 which suddenly made this appear.
The problem was being caused by set_xcomargs_dependencies being called once for each class in the hierarchy, and each of them doing the same logic.
The fix is to look at the actual function of
self.__init__and compare it to the function we're about to call so that we don't set dependencies until we have finished the "outer" most class's apply_defaults invocation.