Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Is /not Null filter for value is None on webui #26584

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Support Is /not Null filter for value is None on webui #26584

merged 3 commits into from
Oct 11, 2022

Conversation

chenglongyan
Copy link
Contributor

@chenglongyan chenglongyan commented Sep 22, 2022

Snapshot:


image

closes: #26427
related: #26461


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 22, 2022
@potiuk
Copy link
Member

potiuk commented Sep 22, 2022

looks like some tests are failing?

@ashb
Copy link
Member

ashb commented Sep 23, 2022

From a "SQL" point of view "" (emptry string) is different to None, (SQL NULL). As you've written your patch it's not possible to find values with an empty string.

Is it worth adding two extra filters for "is null" and "is not null"?

@chenglongyan
Copy link
Contributor Author

Agreed, there are ambiguities...

From a "SQL" point of view "" (emptry string) is different to None, (SQL NULL).

@chenglongyan chenglongyan changed the title Support Not/Equal To filter for value is None on webui Support Is /not Null filter for value is None on webui Sep 25, 2022
@ashb ashb added this to the Airflow 2.5.0 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not get task which status is null
5 participants