Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm install command #25479

Closed
wants to merge 1 commit into from
Closed

fix helm install command #25479

wants to merge 1 commit into from

Conversation

eff917
Copy link

@eff917 eff917 commented Aug 2, 2022

bitnami postgresql subchart fails without userPermissions.enabled on some systems (eg. on minikube).
See bitnami/charts#1210 for details.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

bitnami postgresql subchart fails without userPermissions.enabled on some systems (eg. on minikube).
See bitnami/charts#1210 for details.
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 2, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Aug 2, 2022

LGTM @jedcunningham @dstandish ?

@jedcunningham
Copy link
Member

I don't think we should document extra config being (seemingly) required for an install to work in the first example on the homepage. If that was the case, it should set it by default anyways.

We should find another place to document this. We almost need a different page for this type of thing, because I also think the ArgoCD section is out of place on the homepage as well.

@eff917
Copy link
Author

eff917 commented Aug 3, 2022

I don't think we should document extra config being (seemingly) required for an install to work in the first example on the homepage. If that was the case, it should set it by default anyways.

We should find another place to document this. We almost need a different page for this type of thing, because I also think the ArgoCD section is out of place on the homepage as well.

I agree, but didn't really know where or how to insert it. I see 3 options:

  1. this one
  2. put it in a note section under/over the code block
  3. change the subchart/helm chart default value, so this setting is not needed explicitly

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 18, 2022
@github-actions github-actions bot closed this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:documentation stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants