-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auto refresh to dags home page #22900
Conversation
@bbovenzi I would appreciate your feedback on this. |
8de20e3
to
93757f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! A few comments
- Let's avoid refreshing when the page isn't focused (see
graph.js
) - The formatting of the loading dots and auto-refresh text breaks on screens below 1380px in width. Let's change the
.refresh-actions > .switch-label {
inmain.css
tomargin: 0 10px;
- In grid and graph, we turn off refresh when there are no longer any active runs. I wonder if we should something similar here or at least increase the refresh interval.
@bbovenzi thanks for the review.
|
@bbovenzi for some reason I can't reproduce this break. I removed the margin now hopefully it looks ok. |
Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I think people will be really excited to have this.
But let's not merge until 2.3.0b1 is out
Thanks @bbovenzi! 😃 |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@bbovenzi can this be merged now? |
OMG! this is AWESOME ❤️ |
Add auto refresh functionality to the home page (dags).
closes: #22418
refresh every 2 seconds:
before:
after: