Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout and retry to the BigQueryInsertJobOperator #22395

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Add timeout and retry to the BigQueryInsertJobOperator #22395

merged 1 commit into from
Mar 21, 2022

Conversation

lwyszomi
Copy link
Contributor

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@lwyszomi lwyszomi requested a review from turbaszek as a code owner March 21, 2022 08:28
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 21, 2022
@lwyszomi lwyszomi force-pushed the bigquery_timeout branch 2 times, most recently from a5afdac to 0da8103 Compare March 21, 2022 11:10
eladkal
eladkal approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (left one comment/question)

airflow/providers/google/cloud/hooks/bigquery.py Outdated Show resolved Hide resolved
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

1 similar comment
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 21, 2022
@eladkal eladkal merged commit 14e6b65 into apache:main Mar 21, 2022
@eladkal
Copy link
Contributor

eladkal commented Mar 21, 2022

thanks @lwyszomi

@potiuk potiuk mentioned this pull request Mar 22, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees
No one assigned
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwyszomi @eladkal