Fix handling some None parameters in kubernetes 23 libs #21905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:cncf-kubernetes
potiuk
changed the title
|
This is the last one that failed our |
jedcunningham
requested changes
Mar 1, 2022
potiuk
force-pushed
the
more-picky-kuberenetes-library
branch
2 times, most recently
from
ea1fc41 to
41ef3b8
Compare
|
All should be fixed @jedcunningham |
potiuk
force-pushed
the
more-picky-kuberenetes-library
branch
from
41ef3b8 to
27b9929
Compare
|
Fixed. The tests are monstrous now :) |
potiuk
force-pushed
the
more-picky-kuberenetes-library
branch
2 times, most recently
from
58ff7e7 to
c75d04a
Compare
jedcunningham
approved these changes
Mar 1, 2022
|
Sorry for that @jedcunningham. I think I need to go to sleep. :) |
Kubernetes 23.* is more picky when it comes to values passed to Pod Generator - it requires: * imagePullPolicy * dnsPolicy * restartPolicy to be not None. We are fixing it in the way, that we simply skip setting those if they are None.
|
All good 🍺 |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
more-picky-kuberenetes-library
branch
from
c75d04a to
4557b34
Compare
potiuk
changed the title
Done |
potiuk
added a commit
that referenced
this pull request
Mar 26, 2022
Kubernetes 23.* is more picky when it comes to values passed to Pod Generator - it requires: * imagePullPolicy * dnsPolicy * restartPolicy to be not None. We are fixing it in the way, that we simply skip setting those if they are None. (cherry picked from commit e856aba)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
Kubernetes 23.* is more picky when it comes to values passed to Pod Generator - it requires: * imagePullPolicy * dnsPolicy * restartPolicy to be not None. We are fixing it in the way, that we simply skip setting those if they are None. (cherry picked from commit e856aba)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
Kubernetes 23.* is more picky when it comes to values passed to Pod Generator - it requires: * imagePullPolicy * dnsPolicy * restartPolicy to be not None. We are fixing it in the way, that we simply skip setting those if they are None. (cherry picked from commit e856aba)
36 tasks
potiuk
added a commit
that referenced
this pull request
Mar 28, 2022
)" This reverts commit 24c84f0.
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 28, 2022
)" This reverts commit 24c84f0.
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 28, 2022
)" This reverts commit 24c84f0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 23.* is more picky when it comes to values passed to
Pod Generator - it requires:
to be not None.
We are fixing it in the way, that we simply skip setting those
if they are None.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.