Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags inside try block. #21784

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

jhtimmins
Copy link
Contributor

Forces the Sentry customization to occur in the scope in which tags are called.

@ashb
Copy link
Member

ashb commented Feb 25, 2022

Do we need to/can we add tests for this to prevent regression?

@masterlittle
Copy link
Contributor

Any idea in which release this is gonna be merged?

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 27, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Mar 27, 2022

Do we need to/can we add tests for this to prevent regression?

I tihnk it's not worth to find a clever way to test it ? (But @jhtimmins maybe you can find one?)

@potiuk
Copy link
Member

potiuk commented Mar 27, 2022

Any idea in which release this is gonna be merged?

We are just voting on 2.2.5 so most likely in 2.3.0

@mikharkiv
Copy link

Do we have any updates about when this fix will be merged?

@potiuk
Copy link
Member

potiuk commented Apr 28, 2022

Seems it's been forgotten.

@potiuk potiuk merged commit 190e911 into apache:main Apr 28, 2022
@eladkal eladkal added this to the Airflow 2.3.1 milestone Apr 28, 2022
@eladkal
Copy link
Contributor

eladkal commented Apr 28, 2022

If there will be another RC for 2.3.0 maybe this can get in otherwise it will be in 2.3.1

@jedcunningham jedcunningham deleted the fix-sentry-missing-tags branch April 28, 2022 18:42
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 8, 2022
ephraimbuddy pushed a commit that referenced this pull request May 8, 2022
(cherry picked from commit 190e911)
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
(cherry picked from commit 190e911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants