-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags inside try block. #21784
Add tags inside try block. #21784
Conversation
Do we need to/can we add tests for this to prevent regression? |
Any idea in which release this is gonna be merged? |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
I tihnk it's not worth to find a clever way to test it ? (But @jhtimmins maybe you can find one?) |
We are just voting on 2.2.5 so most likely in 2.3.0 |
Do we have any updates about when this fix will be merged? |
Seems it's been forgotten. |
If there will be another RC for 2.3.0 maybe this can get in otherwise it will be in 2.3.1 |
(cherry picked from commit 190e911)
(cherry picked from commit 190e911)
Forces the Sentry customization to occur in the scope in which tags are called.