Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config worker_enable_remote_control for celery #21507

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Feb 11, 2022

so that we have control over it

since when the value is true, it keeps creating .*reply-celery-pidbox queues in SQS if the flag is true

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@pingzh pingzh force-pushed the pingzh-worker_enable_remote_control branch from 1c09d7d to 9a43592 Compare February 11, 2022 00:56
@pingzh pingzh requested a review from mik-laj as a code owner February 11, 2022 00:56
Copy link
Member

@KevinYang21 KevinYang21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call it out in the description that this is for SQS too.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 11, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@potiuk potiuk merged commit 2cab0bd into apache:main Feb 11, 2022
@pingzh pingzh deleted the pingzh-worker_enable_remote_control branch February 14, 2022 18:20
@jedcunningham jedcunningham added the type:improvement Changelog: Improvements label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants