Rename task_concurrency to max_active_tis_per_dag
#17708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Scheduler
kaxil
force-pushed
the
task-concurrency-rename
branch
from
adb98e2 to
ce5f881
Compare
potiuk
reviewed
Aug 19, 2021
| @@ -887,6 +887,7 @@ def test_no_new_fields_added_to_base_operator(self): | |||
| 'executor_config': {}, | |||
| 'inlets': [], | |||
| 'label': '10', | |||
| 'max_active_tis_per_dag': None, | |||
There was a problem hiding this comment.
What's the purpose of this test BTW? We had another PR About it and I was not sure why we have the list here.
There was a problem hiding this comment.
This list just makes sure that if new fields are added to the base operator we add it here, in case it needs any special treatment for DAG Serialization (helpful if they are dicts and lists)
potiuk
approved these changes
Aug 19, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
force-pushed
the
task-concurrency-rename
branch
from
ce5f881 to
4f1d55c
Compare
ashb
approved these changes
Aug 19, 2021
Follow-up of apache#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand
kaxil
force-pushed
the
task-concurrency-rename
branch
from
4f1d55c to
5176677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #16267
Renames
task_concurrencytomax_active_tis_per_dagSome of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example:
This PR is an attempt to make the settings easier to understand
ToDo:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.