Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breeze kind-cluster deploy failing with ECONREFUSED #17293

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

ephraimbuddy
Copy link
Contributor

Currently, kind-cluster deploy fails occasionally due to yarn install when compiling
assets. This PR fixes it by using the recommended option --network-concurrency=1 when
running yarn install

+ yarn install --frozen-lockfile --no-cache
/opt/airflow/airflow/www /opt/airflow
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/colorette/-/colorette-1.2.2.tgz: connect ECONNREFUSED 104.16.22.35:443".
info If you think this is a bug, please open a bug report with the information provided in "/opt/airflow/airflow/www/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/bash -o pipefail -e -u -x -c if [[ ${AIRFLOW_INSTALLATION_METHOD} == "." ]]; then         bash /scripts/docker/compile_www_assets.sh;     fi;     if [[ ${INSTALL_FROM_DOCKER_CONTEXT_FILES} == "true" ]]; then         bash /scripts/docker/install_from_docker_context_files.sh;     elif [[ ${INSTALL_FROM_PYPI} == "true" ]]; then         bash /scripts/docker/install_airflow.sh;     fi;     if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then         bash /scripts/docker/install_additional_dependencies.sh;     fi;     find /root/.local/ -name '*.pyc' -print0 | xargs -0 rm -r || true ;     find /root/.local/ -type d -name '__pycache__' -print0 | xargs -0 rm -r || true ;     find /root/.local -executable -print0 | xargs --null chmod g+x;     find /root/.local -print0 | xargs --null chmod g+rw' returned a non-zero code: 1

ERROR: The previous step completed with error. Please take a look at output above

See: yarnpkg/yarn#5299


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Currently, kind-cluster deploy fails occasionally due to yarn install when compiling
assets. This PR fixes it by using the recommended option --network-concurrency=1 when
running yarn install
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 28, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

Hmm, main is broken… this PR is fine on itself.

@uranusjr uranusjr merged commit 53e9349 into apache:main Jul 29, 2021
@uranusjr uranusjr deleted the fix-failing-kube-deploy branch July 29, 2021 01:13
potiuk pushed a commit to potiuk/airflow that referenced this pull request Aug 2, 2021
Currently, kind-cluster deploy fails occasionally due to yarn install when compiling
assets. This PR fixes it by using the recommended option --network-concurrency=1 when
running yarn install

(cherry picked from commit 53e9349)
kaxil pushed a commit that referenced this pull request Aug 17, 2021
Currently, kind-cluster deploy fails occasionally due to yarn install when compiling
assets. This PR fixes it by using the recommended option --network-concurrency=1 when
running yarn install

(cherry picked from commit 53e9349)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
Currently, kind-cluster deploy fails occasionally due to yarn install when compiling
assets. This PR fixes it by using the recommended option --network-concurrency=1 when
running yarn install

(cherry picked from commit 53e9349)
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 19, 2021
The --network-concurrency=1 is very slow and even if this has
been added in apache#17293 to battle connection refused, it slows regular
builds far too much.

There is a new optimisation in progress that should significantly
reduce the yarn installations on kind-cluster deploy: apache#19210 and
it should solve the problem much better.
potiuk added a commit that referenced this pull request Nov 19, 2021
The --network-concurrency=1 is very slow and even if this has
been added in #17293 to battle connection refused, it slows regular
builds far too much.

There is a new optimisation in progress that should significantly
reduce the yarn installations on kind-cluster deploy: #19210 and
it should solve the problem much better.
potiuk added a commit that referenced this pull request Jan 22, 2022
The --network-concurrency=1 is very slow and even if this has
been added in #17293 to battle connection refused, it slows regular
builds far too much.

There is a new optimisation in progress that should significantly
reduce the yarn installations on kind-cluster deploy: #19210 and
it should solve the problem much better.

(cherry picked from commit 43e84cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants