Bugfix: Task docs are not shown in the Task Instance Detail View #15191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
ashb,
mik-laj,
ryanahamilton,
turbaszek,
vikramkoka and
XD-DENG
as code owners
boring-cyborg
bot
added
area:serialization
area:webserver
kaxil
commented
Apr 4, 2021
| @@ -1247,7 +1247,7 @@ def task(self): | |||
| # Color coding the special attributes that are code | |||
| special_attrs_rendered = {} | |||
| for attr_name in wwwutils.get_attr_renderer(): | |||
| if hasattr(task, attr_name): | |||
| if getattr(task, attr_name, None) is not None: | |||
There was a problem hiding this comment.
This is to not show attributes that are None -- that pollutes the TaskInstance screen.
kaxil
commented
Apr 4, 2021
| @@ -338,7 +338,7 @@ def json_render(obj, lexer): | |||
| return out | |||
|
|
|||
|
|
|||
| def wrapped_markdown(s, css_class=None): | |||
| def wrapped_markdown(s, css_class='rich_doc'): | |||
There was a problem hiding this comment.
It was always rich_doc in 1.10.x , example:
https://github.com/apache/airflow/blob/1.10.15/airflow/www_rbac/utils.py#L316-L322
However, we pass None at few places, so just making it the default
kaxil
force-pushed
the
fix-ti-docmd
branch
3 times, most recently
from
2e46817 to
1d012c0
Compare
vikramkoka
approved these changes
Apr 4, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
closes apache#15178 closes apache#13761 This feature was added in 2015 in apache#74 and it was expected to set `doc_md` (or `doc_rst` and other `doc_*`) via `task.doc_md` instead of passing via arg. However, this did not work with DAG Serialization as we only allowed a selected args to be stored in Serialized version of DAG.
kaxil
added a commit
that referenced
this pull request
Apr 9, 2021
) closes #15178 closes #13761 This feature was added in 2015 in #74 and it was expected to set `doc_md` (or `doc_rst` and other `doc_*`) via `task.doc_md` instead of passing via arg. However, this did not work with DAG Serialization as we only allowed a selected args to be stored in Serialized version of DAG. (cherry picked from commit e86f5ca)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
) closes #15178 closes #13761 This feature was added in 2015 in #74 and it was expected to set `doc_md` (or `doc_rst` and other `doc_*`) via `task.doc_md` instead of passing via arg. However, this did not work with DAG Serialization as we only allowed a selected args to be stored in Serialized version of DAG. (cherry picked from commit e86f5ca)
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15178
closes #13761
This feature was added in 2015 in #74 and it was expected to set
doc_md(ordoc_rstand otherdoc_*) viatask.doc_mdinstead of passing via arg. However, this did not work with DAG Serialization as we only allowed a selected args to be stored in Serialized version of DAG.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.