Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Pip version when building image. #14368

Closed
wants to merge 1 commit into from

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 22, 2021

The initial problem with the new PIP resolved in 20.3 version have
been successfully solved. Seems that version 21.* is much more
stable and actually works in all cases, so we are switching back
to it.

Also changed pip and wheel dependencies to ~= (compatible) version
hoping that the experience of backwards incomptible release in
major version update have been adopted by the PIP team with
21* series release.

Closes #12838


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Dockerfile Outdated Show resolved Hide resolved
@potiuk
Copy link
Member Author

potiuk commented Feb 23, 2021

Just as a comment - still we will not merge it yet - PIP 21.* still has some problems with installing providers (it again downloads multiple version of some packages and it takes > 30 minutes) and I need to take a look :). It's likely something that we can improve in our scripts, but it also means that installing using constraints is very important as PIP resolver still does not handle everything as smoothly as we would like to (but maybe this has something to do with conflicting dependencies in some cases)

@ashb ashb marked this pull request as draft February 23, 2021 09:56
@ashb
Copy link
Member

ashb commented Feb 23, 2021

Just as a coment - still we will not merge it yet - PIP 21.* still have some problems with installing providers (it again downloads multiple version of some packages and it takes > 30 minutes) and I need to take a look :)

I've converted this PR to draft then so it doesn't get merged by mistake.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 23, 2021
@potiuk potiuk force-pushed the use-latest-pip branch 2 times, most recently from 9e5ceed to 9ec11b5 Compare March 20, 2021 18:41
The initial problem with the new PIP resolved in 20.3 version have
been successfully solved. Seems that version 21.* is much more
stable and actually works in all cases, so we are switching back
to it.

Also changed pip and wheel dependencies to ~= (compatible) version
hoping that the experience of backwards incomptible release in
major version update have been adopted by the PIP team with
21* series release.

Closes apache#12838
@potiuk potiuk closed this Apr 3, 2021
@potiuk potiuk deleted the use-latest-pip branch April 3, 2021 20:09
@uranusjr
Copy link
Member

uranusjr commented Apr 7, 2021

Is this no longer relevant, or are there blockers making this inviable?

@potiuk
Copy link
Member Author

potiuk commented Apr 7, 2021

Blockers. Apache Beam needs to be released including this PR : apache/beam#14328

@potiuk
Copy link
Member Author

potiuk commented Apr 7, 2021

But i will do it when they release

@uranusjr
Copy link
Member

uranusjr commented Apr 7, 2021

Thanks for the context.

@potiuk potiuk restored the use-latest-pip branch April 26, 2022 20:45
@potiuk potiuk deleted the use-latest-pip branch July 29, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIP 20.3 might break Airflow installation
3 participants