-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest Pip version when building image. #14368
Conversation
Just as a comment - still we will not merge it yet - PIP 21.* still has some problems with installing providers (it again downloads multiple version of some packages and it takes > 30 minutes) and I need to take a look :). It's likely something that we can improve in our scripts, but it also means that installing using constraints is very important as PIP resolver still does not handle everything as smoothly as we would like to (but maybe this has something to do with conflicting dependencies in some cases) |
I've converted this PR to draft then so it doesn't get merged by mistake. |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
9e5ceed
to
9ec11b5
Compare
The initial problem with the new PIP resolved in 20.3 version have been successfully solved. Seems that version 21.* is much more stable and actually works in all cases, so we are switching back to it. Also changed pip and wheel dependencies to ~= (compatible) version hoping that the experience of backwards incomptible release in major version update have been adopted by the PIP team with 21* series release. Closes apache#12838
Is this no longer relevant, or are there blockers making this inviable? |
Blockers. Apache Beam needs to be released including this PR : apache/beam#14328 |
But i will do it when they release |
Thanks for the context. |
The initial problem with the new PIP resolved in 20.3 version have
been successfully solved. Seems that version 21.* is much more
stable and actually works in all cases, so we are switching back
to it.
Also changed pip and wheel dependencies to ~= (compatible) version
hoping that the experience of backwards incomptible release in
major version update have been adopted by the PIP team with
21* series release.
Closes #12838
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.