Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds warning about ongoing problems wit PIP 20.3 to bug template #12839

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 5, 2020

Part of #12838


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk force-pushed the add-warning-about-pip-installation-problems-to-bug-template branch from 9cfe123 to d34e33b Compare December 5, 2020 17:41
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this in the template.

The one pinned is explicit and grabs attention -- good work on that

image

@potiuk
Copy link
Member Author

potiuk commented Dec 6, 2020

Let's see how the story evolves. I am afraid, that when we start announcing 2.0 and 1.10.14, we will be flooded with "Airflow does not install" issues.

And the more we protect against it, the better. In several places (unless of course pypa/pip#9231 or similar workaround gets implemented).

I also would like all of us, committers to be aware that we have those problems with PyPI, so I do not end up as a person handling all such PyPI -related issues like #12824. I got redirected to as 'local PIP expert there", but honestly, I do not feel like a person that all the "PIP 20.3 installation of Airflow is broken" should be directed to (or to any of the committers with that respect).

IMHO, the more vocal we are about it and proactively we tell about the problem the more likely our users will notice and downgrade PIP without involving slack conversations or opening issues.

I just do not want to say "we've done enough to warn our users" situation like PIP did. Surely, we can blame our users for not reading the docs, but this is the last thing I would do.

@potiuk potiuk marked this pull request as draft December 8, 2020 01:11
@potiuk potiuk closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants