Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify string expressions #12123

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 6, 2020

Black has trouble formatting strings that are too long and produces unusual sring expressions.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested review from XD-DENG and mik-laj November 6, 2020 01:35
@boring-cyborg boring-cyborg bot added area:CLI area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Nov 6, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2020

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 6, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

Copy link
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix needed. Block to avoid accidental merge

@github-actions github-actions bot removed the okay to merge It's ok to merge this PR as it does not require more tests label Nov 6, 2020
Black has trouble formatting strings that are too long and produces unusual sring expressions.
@kaxil kaxil force-pushed the Simplify-string-expressions branch from 32582ea to dbb14f1 Compare November 6, 2020 12:13
@kaxil
Copy link
Member Author

kaxil commented Nov 6, 2020

Fix needed. Block to avoid accidental merge

Fixed

@github-actions
Copy link

github-actions bot commented Nov 6, 2020

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 6, 2020
@XD-DENG XD-DENG merged commit cf9437d into apache:master Nov 6, 2020
@kaxil kaxil deleted the Simplify-string-expressions branch November 6, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants