-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acl_policy into GCSToS3Operator (#10804) #10829
Add acl_policy into GCSToS3Operator (#10804) #10829
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
16880aa
to
faebeb1
Compare
faebeb1
to
04c99e7
Compare
68f48eb
to
a45842b
Compare
@@ -82,6 +82,9 @@ class GCSToS3Operator(BaseOperator): | |||
Service Account Token Creator IAM role to the directly preceding identity, with first | |||
account from the list granting this role to the originating account (templated). | |||
:type google_impersonation_chain: Union[str, Sequence[str]] | |||
:param acl_policy: Optional The string to specify the canned ACL policy for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we renamed it to s3_acl_policy
to make it more explicit?
a45842b
to
34a15df
Compare
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
34a15df
to
137aacf
Compare
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
137aacf
to
16cb3cd
Compare
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The Build Workflow run is cancelling this PR. The job has been cancelled by another workflow. |
16cb3cd
to
d9586ff
Compare
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
Awesome work, congrats on your first merged pull request! |
closes: #10804