Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acl_policy into GCSToS3Operator (#10804) #10829

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

amaterasu-coder
Copy link
Contributor

@amaterasu-coder amaterasu-coder commented Sep 9, 2020

closes: #10804

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Sep 9, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 9, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from 16880aa to faebeb1 Compare September 9, 2020 12:37
@amaterasu-coder amaterasu-coder marked this pull request as ready for review September 9, 2020 13:11
@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from faebeb1 to 04c99e7 Compare September 10, 2020 15:06
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 10, 2020
@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch 3 times, most recently from 68f48eb to a45842b Compare September 28, 2020 11:38
@@ -82,6 +82,9 @@ class GCSToS3Operator(BaseOperator):
Service Account Token Creator IAM role to the directly preceding identity, with first
account from the list granting this role to the originating account (templated).
:type google_impersonation_chain: Union[str, Sequence[str]]
:param acl_policy: Optional The string to specify the canned ACL policy for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we renamed it to s3_acl_policy to make it more explicit?

@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from a45842b to 34a15df Compare October 5, 2020 07:13
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from 34a15df to 137aacf Compare October 5, 2020 07:41
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from 137aacf to 16cb3cd Compare October 5, 2020 08:28
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. The job has been cancelled by another workflow.

@amaterasu-coder amaterasu-coder force-pushed the acl-policy-gcstos3operator branch from 16cb3cd to d9586ff Compare October 5, 2020 14:37
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@mik-laj mik-laj merged commit dd98b21 into apache:master Oct 6, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 6, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add acl_policy into GCSToS3Operator
3 participants