Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include .Values.volumeMounts into chart/templates/cleanup/cleanup-cronjob.yaml #40191

Closed
1 of 2 tasks
iiskandarov-clgx opened this issue Jun 12, 2024 · 6 comments · Fixed by #42268
Closed
1 of 2 tasks

Include .Values.volumeMounts into chart/templates/cleanup/cleanup-cronjob.yaml #40191

iiskandarov-clgx opened this issue Jun 12, 2024 · 6 comments · Fixed by #42268
Assignees
@sanskrutikhedkar9
Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests

Comments

@iiskandarov-clgx
Copy link

Description

Since all templates supported airflow_config_mount supports Values.volumeMounts (except cleanup-cronjob.yaml)
Is it possible to add Values.volumeMounts support to cleanup-cronjob.yaml as well?

Thank you

Use case/motivation

use custom ConfigMap for airflow_local_settings.py instead of .Values.airflowLocalSettings

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@iiskandarov-clgx iiskandarov-clgx added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jun 12, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 12, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@vatsrahul1001 vatsrahul1001 added area:helm-chart Airflow Helm Chart and removed needs-triage label for new issues that we didn't triage yet labels Jun 12, 2024
@potiuk
Copy link
Member

potiuk commented Jun 12, 2024

Sure. Feel free to add it.

@sanskrutikhedkar9
Copy link

I am interested. Could you please assign this to me

@potiuk
Copy link
Member

potiuk commented Jun 12, 2024

Done

@amoghrajesh
Copy link
Contributor

@sanskrutikhedkar9 are you working on this actively?

@dada-engineer
Copy link
Contributor

dada-engineer commented Sep 17, 2024 •
edited
Loading

I would like to jump in here and fix this issue alongside with a problem that you are not able to deactivate the job history because the check {{ if .Values.cleanup.successfulJobsHistoryLimit }} is false if I use --set cleanup.successfulJobsHistoryLimit=0 and then the default of k8s (3) is used.

Are you fine with this or do you prefer a separate issue here?

@dada-engineer dada-engineer mentioned this issue Sep 17, 2024
Merged
romsharon98 pushed a commit that referenced this issue Sep 17, 2024
@dada-engineer
fix(helm): render global volumes and volume mounts into cleanup job (#…
20a481c 
…40191) (#42268)

* fix(helm): render global volumes and volume mounts in cleanup job (#64056)

* fix(helm): allow to deactivate cleanup job history (#64056)
gopidesupavan pushed a commit to gopidesupavan/airflow that referenced this issue Sep 17, 2024
@dada-engineer @gopidesupavan
fix(helm): render global volumes and volume mounts into cleanup job (a…
1e6989a 
…pache#40191) (apache#42268)

* fix(helm): render global volumes and volume mounts in cleanup job (#64056)

* fix(helm): allow to deactivate cleanup job history (#64056)
joaopamaral pushed a commit to joaopamaral/airflow that referenced this issue Oct 21, 2024
@dada-engineer @joaopamaral
fix(helm): render global volumes and volume mounts into cleanup job (a…
660111a 
…pache#40191) (apache#42268)

* fix(helm): render global volumes and volume mounts in cleanup job (#64056)

* fix(helm): allow to deactivate cleanup job history (#64056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanskrutikhedkar9 sanskrutikhedkar9

Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(helm): render global volumes and volume mounts into cleanup job (#40191) dada-engineer/airflow
6 participants
@potiuk @dada-engineer @amoghrajesh @vatsrahul1001 @sanskrutikhedkar9 @iiskandarov-clgx