Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go to docker images #21545

Closed
2 tasks done
pierrejeambrun opened this issue Feb 13, 2022 · 8 comments · Fixed by #22296
Closed
2 tasks done

Add Go to docker images #21545

pierrejeambrun opened this issue Feb 13, 2022 · 8 comments · Fixed by #22296
Assignees
Labels

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Feb 13, 2022

Description

Following #20386 we are now supporting execution of Beam Pipeline written in Go.

We might want to add Go to the images.

Beam Go SDK first stable release is v2.33.0 and requires Go v1.16 minimum:

Use case/motivation

This way people running airflow from docker can build/run their go pipelines.

Related issues

Issue:
#20283

PR:
#20386

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pierrejeambrun pierrejeambrun added the kind:feature Feature Requests label Feb 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 13, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk potiuk self-assigned this Feb 13, 2022
@pierrejeambrun
Copy link
Member Author

@potiuk as requested, here is the issue :)

@potiuk
Copy link
Member

potiuk commented Feb 13, 2022

I will see how much go will add to the size of the image and decide :)

@potiuk
Copy link
Member

potiuk commented Feb 13, 2022

The worst case we can add instructions/examples how to do it in our "extending image" chapter.

@mik-laj
Copy link
Member

mik-laj commented Feb 13, 2022

I think we should add the guide to the "Recipes" section in docker-stack documentation package. https://airflow.apache.org/docs/docker-stack/recipes.html

We already have a guide on how to install additional tools:

  • Google Cloud SDK, which is needed for GKEPodOperator, DataflowStartSqlJobOperator, and others.
  • JRE, which is needed for DataflowCreateJavaJobOperator, and many others.

@potiuk
Copy link
Member

potiuk commented Feb 26, 2022

Agree - added "good first issue" label.

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Mar 15, 2022

Hello @potiuk,

I would be glad to help with the go recipe.

Let me know if you want me to work on it :)

Best,

@potiuk
Copy link
Member

potiuk commented Mar 15, 2022

Feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants