Skip to content

Commit

Permalink
Cleanup dependencies of cache image pushing and ARM image build (#35117)
Browse files Browse the repository at this point in the history
The cache image pushing should only happen after all tests
succeeded and constraints got pushed.
  • Loading branch information
potiuk authored Oct 23, 2023
1 parent 8de8ba7 commit e19ce43
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1725,7 +1725,6 @@ jobs:
- tests-postgres
- tests-integration-postgres
- tests-integration-mysql
- push-early-buildx-cache-to-github-registry
# Skip when generate constraints fails
- generate-constraints
env:
Expand Down Expand Up @@ -1779,8 +1778,7 @@ jobs:
runs-on: ${{fromJSON(needs.build-info.outputs.runs-on)}}
needs:
- build-info
- generate-constraints
- docs
- update-constraints
if: needs.build-info.outputs.canary-run == 'true'
strategy:
fail-fast: false
Expand Down Expand Up @@ -1865,6 +1863,10 @@ jobs:
run: breeze ci fix-ownership
if: always()

# This is only a check if ARM images are successfully building when committer runs PR from
# Apache repository. This is needed in case you want to fix failing cache job in "canary" run
# There is no point in running this one in "canary" run, because the above step is doing the
# same build anyway.
build-ci-arm-images:
timeout-minutes: 50
name: >
Expand All @@ -1873,8 +1875,8 @@ jobs:
runs-on: ${{fromJSON(needs.build-info.outputs.runs-on)}}
needs:
- build-info
- wait-for-ci-images
- wait-for-prod-images
- generate-constraints
- docs
- static-checks
- tests-sqlite
- tests-mysql
Expand All @@ -1888,7 +1890,6 @@ jobs:
# Force more parallelism for build even on small instances
PARALLELISM: 6
if: >
needs.build-info.outputs.upgrade-to-newer-dependencies != 'false' &&
needs.build-info.outputs.in-workflow-build == 'true' &&
needs.build-info.outputs.canary-run != 'true'
steps:
Expand Down

0 comments on commit e19ce43

Please sign in to comment.