Skip to content

Commit

Permalink
Add better diagnostics on auto dependencies upgrade (#27215)
Browse files Browse the repository at this point in the history
Whenever upgrade-to-newer-dependencies is set, our CI will attempt
to upgrade all dependencies to latest versions released. However so
far it was not clear which dependencies were upgraded so if CI
failed because of some dependency release, you had to guess and
manually check which dependencies got upgraded.

This PR adds a step that will show the diff between the constraints
in the target branch (`constraints-main` or `constraints-X-Y` in
case upgrade-to-newer-dependencies is enabled.
  • Loading branch information
potiuk authored Oct 23, 2022
1 parent dd40e60 commit 8f5ed4b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
DOCKER_CACHE: ${{ needs.build-info.outputs.cache-directive }}
IMAGE_TAG: ${{ env.IMAGE_TAG_FOR_THE_BUILD }}
PYTHON_VERSIONS: ${{ needs.build-info.outputs.all-python-versions-list-as-string }}
- name: "Show dependencies to be upgraded"
run: >
breeze release-management generate-constraints
--airflow-constraints-mode constraints-source-providers
if: needs.build-info.outputs.upgrade-to-newer-dependencies != 'false'
- name: Push empty CI image ${{ env.PYTHON_MAJOR_MINOR_VERSION }}:${{ env.IMAGE_TAG_FOR_THE_BUILD }}
if: failure() || cancelled()
run: breeze ci-image build --push --empty-image --run-in-parallel
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,11 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
PYTHON_VERSIONS: ${{ needs.build-info.outputs.all-python-versions-list-as-string }}
DEBUG_RESOURCES: ${{ needs.build-info.outputs.debug-resources }}
if: needs.build-info.outputs.in-workflow-build == 'true'
- name: "Show dependencies to be upgraded"
run: >
breeze release-management generate-constraints
--airflow-constraints-mode constraints-source-providers
if: needs.build-info.outputs.upgrade-to-newer-dependencies != 'false'
- name: "Candidates for pip resolver backtrack triggers"
if: failure() || cancelled()
run: >
Expand Down

0 comments on commit 8f5ed4b

Please sign in to comment.