Skip to content

Commit

Permalink
docs(newsfragments): add 44475.significant.rst
Browse files Browse the repository at this point in the history
  • Loading branch information
Lee-W committed Nov 30, 2024
1 parent 8bd8f04 commit 477fdf0
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
21 changes: 21 additions & 0 deletions newsfragments/44475.significant.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
Remove ``TriggerRule.NONE_FAILED_OR_SKIPPED``

.. Provide additional contextual information
.. Check the type of change that applies to this change
* Types of change

* [x] DAG changes
* [ ] Config changes
* [ ] API changes
* [ ] CLI changes
* [ ] Behaviour changes
* [ ] Plugin changes
* [ ] Dependency change

.. List the migration rules needed for this change (see https://github.com/apache/airflow/issues/41641)
* Migrations rules needed

* Remove attribute ``TriggerRule.NONE_FAILED_OR_SKIPPED``
2 changes: 1 addition & 1 deletion tests/utils/test_trigger_rule.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_valid_trigger_rules(self):
assert TriggerRule.is_valid(TriggerRule.ALWAYS)
assert TriggerRule.is_valid(TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS)
assert TriggerRule.is_valid(TriggerRule.ALL_DONE_SETUP_SUCCESS)
assert len(TriggerRule.all_triggers()) == 13
assert len(TriggerRule.all_triggers()) == 12

with pytest.raises(ValueError):
TriggerRule("NOT_EXIST_TRIGGER_RULE")

0 comments on commit 477fdf0

Please sign in to comment.