-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misspellings in many AGE files #985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most corrections automatically suggested by Google Sheets. All fault mine
/* vertex entry for the vertex_hastable */ | ||
/* vertex entry for the vertex_hashtable */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one need to be checked in source code as well.
The changes that affect spellings in actual code and not just comments might have had an issue, but all regression tests passed, and I reviewed all of the changes manually myself. It looks good, but can you squash all the commits down into one commit? |
@dehowef squashed |
Looks good to me. |
@jsoref Please squash your comments to something more descriptive without listing all of the words fixed. For example, for the commit description, something like "Fix misspellings in many AGE files (#985)" For example, for the more detailed descriptions, mention what was done (a general description) and why. But, you don't need to list all of the individual changes. Just a good summary. |
@jsoref @dehowef @muhammadshoaib There are code reviews that need to be resolved. |
Signed-off-by: Josh Soref <[email protected]>
@jsoref -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but please change the description of the commit to a brief summary
@jsoref Please see above comments that are still waiting for you. |
Corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling). The misspellings were reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240 Signed-off-by: Josh Soref <[email protected]>
@jrgemignani is this good enough? |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/age/actions/runs/5251077113#summary-14208871486