-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile as a development environment #943
Conversation
af1cee6
to
84b30af
Compare
@panosfol Will creating an moving the Dockerfile to another directory be okay? |
@jrgemignani IMO it's irrelevant whether we move the Dockerfiles in another directory or keep it at root. This is done just to avoid bloating of the root folder by adding Running via |
@eyab and myself will need to verify that Dockerhub won't be impacted by these changes. That would be my only concern atm, and possibly, other items pointing to, or using, the docker file. Unless, I'm misunderstanding the docker file usage. |
The Dockerfile that is being used by Dockerhub remains unchanged therefore no problem will arise. The new dockerfile that was added is strictly for development puproses. |
@panosfol Once this PR has been approved and merged, you will need to create one tailored to PostgreSQL 11 and submit it against the PG11 branch. |
@jrgemignani Fixed! |
@jrgemignani should this be changed for PG13? And produce 2 more for PG12 and PG11? |
Dockerfile.dev: This variation of the original Dockerfile is introduced to help developers run their testsuite in the build phase of the docker image. .dockerignore: Added .dockerignore to avoid conflicts with ".so" files Signed-off-by: Panagiotis Foliadis <[email protected]>
I'm going to have one other review this and then, provided everything is okay, merge it into the master. Assuming all goes well and there are no issues, you can create those additional PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
…pache#943) Dockerfile.dev: This variation of the original Dockerfile is introduced to help developers run their testsuite in the build phase of the docker image. .dockerignore: Added .dockerignore to avoid conflicts with ".so" files Signed-off-by: Panagiotis Foliadis <[email protected]>
…pache#943) Dockerfile.dev: This variation of the original Dockerfile is introduced to help developers run their testsuite in the build phase of the docker image. .dockerignore: Added .dockerignore to avoid conflicts with ".so" files Signed-off-by: Panagiotis Foliadis <[email protected]>
…pache#943) Dockerfile.dev: This variation of the original Dockerfile is introduced to help developers run their testsuite in the build phase of the docker image. .dockerignore: Added .dockerignore to avoid conflicts with ".so" files Signed-off-by: Panagiotis Foliadis <[email protected]>
Dockerfile.dev:
This variation of the original Dockerfile is introduced to
help developers run their testsuite in the build phase of the
docker image.
.dockerignore:
Added .dockerignore to avoid conflicts with ".so" files
Closes #936