Fix issue 2046: Memory leak during btree(agtype) #2060

jrgemignani · 2024-08-19T16:55:19Z

Fixed the memory leaks during a btree index build.

The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves.

Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies.

No regression tests were impacted.
No additionall regression tests are needed.

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed.

MuhammadTahaNaveed

lgtm

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed.

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed. Conflicts: src/backend/utils/adt/agtype.c

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed. Resolved Conflicts: src/backend/utils/adt/agtype.c

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed.

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed. Conflicts: src/backend/utils/adt/agtype.c

Fixed the memory leaks during a btree index build. The issue has to do with how PostgreSQL allocates and frees its memory. Usually, contexts are destroyed, freeing up the memory in that context for the functions. However, sometimes this destruction happens way too late for it to be helpful. In the case of btree compare, the context destruction doesn't happen until after the sort has completed. The solution is to add in pfrees to manage the memory we use, ourselves. Additionally, propagated these changes to a few other functions. More PRs will be created to address other locations where this applies. No regression tests were impacted. No additionall regression tests are needed. Resolved Conflicts: src/backend/utils/adt/agtype.c

jrgemignani requested review from MuhammadTahaNaveed and rafsun42 August 19, 2024 16:55

jrgemignani mentioned this pull request Aug 19, 2024

Memory leak during btree(agtype) #2046

Closed

github-actions bot added master override-stale To keep issues/PRs untouched from stale action labels Aug 19, 2024

MuhammadTahaNaveed approved these changes Aug 19, 2024

View reviewed changes

MuhammadTahaNaveed merged commit 05487a0 into apache:master Aug 19, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue 2046: Memory leak during btree(agtype) #2060

Fix issue 2046: Memory leak during btree(agtype) #2060

jrgemignani commented Aug 19, 2024

MuhammadTahaNaveed left a comment

Fix issue 2046: Memory leak during btree(agtype) #2060

Fix issue 2046: Memory leak during btree(agtype) #2060

Conversation

jrgemignani commented Aug 19, 2024

MuhammadTahaNaveed left a comment

Choose a reason for hiding this comment