Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 1988: How to update a property which is a keyword #2005

Merged

Conversation

jrgemignani
Copy link
Contributor

Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query.

Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands -

MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.

Copy link
Member

@MuhammadTahaNaveed MuhammadTahaNaveed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! just a minor spelling issue

src/backend/parser/cypher_parser.c Outdated Show resolved Hide resolved
Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
@jrgemignani jrgemignani force-pushed the allow_backticked_keywords branch from e068b6d to a74b298 Compare August 6, 2024 16:31
@MuhammadTahaNaveed MuhammadTahaNaveed merged commit 7b19845 into apache:master Aug 6, 2024
7 checks passed
jrgemignani added a commit to jrgemignani/age that referenced this pull request Aug 6, 2024
)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Aug 6, 2024
)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Aug 6, 2024
)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
jrgemignani added a commit to jrgemignani/age that referenced this pull request Aug 6, 2024
)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
rafsun42 pushed a commit that referenced this pull request Aug 6, 2024
…2017)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
rafsun42 pushed a commit that referenced this pull request Aug 6, 2024
…2016)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
rafsun42 pushed a commit that referenced this pull request Aug 6, 2024
…2015)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
rafsun42 pushed a commit that referenced this pull request Aug 6, 2024
…2014)

Fixed issue 1988: Reserved Keyword Handling: How to update a property
which is a keyword. Basically, how to use a keyword, aka reserved
word, in a query.

Added the appropriate scanner and parser rules to allow keywords to
be back ticked and used in queries as their name. For example, like
in the following commands -

    MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n;
    MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n;

The changes did not break any regression tests.
Added additional regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master override-stale To keep issues/PRs untouched from stale action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants