-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 1988: How to update a property which is a keyword #2005
Merged
MuhammadTahaNaveed
merged 1 commit into
apache:master
from
jrgemignani:allow_backticked_keywords
Aug 6, 2024
Merged
Fix Issue 1988: How to update a property which is a keyword #2005
MuhammadTahaNaveed
merged 1 commit into
apache:master
from
jrgemignani:allow_backticked_keywords
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
master
override-stale
To keep issues/PRs untouched from stale action
labels
Aug 6, 2024
jrgemignani
force-pushed
the
allow_backticked_keywords
branch
from
August 6, 2024 14:49
00f62e5
to
e068b6d
Compare
MuhammadTahaNaveed
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! just a minor spelling issue
Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
jrgemignani
force-pushed
the
allow_backticked_keywords
branch
from
August 6, 2024 16:31
e068b6d
to
a74b298
Compare
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 6, 2024
) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 6, 2024
) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 6, 2024
) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 6, 2024
) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
rafsun42
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2017) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
rafsun42
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2016) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
rafsun42
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2015) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
rafsun42
pushed a commit
that referenced
this pull request
Aug 6, 2024
…2014) Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query. Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands - MATCH (n:Person { id: 123 }) SET n.`match` = 'matched' RETURN n; MATCH (n:Person { id: 123 }) SET n.`create` = 'created' RETURN n; The changes did not break any regression tests. Added additional regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 1988: Reserved Keyword Handling: How to update a property which is a keyword. Basically, how to use a keyword, aka reserved word, in a query.
Added the appropriate scanner and parser rules to allow keywords to be back ticked and used in queries as their name. For example, like in the following commands -
The changes did not break any regression tests.
Added additional regression tests.