Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_graph_oid function declaration return type uint32 definition Oid #2027

Closed
MironAtHome opened this issue Aug 8, 2024 · 4 comments · Fixed by #2039
Closed

get_graph_oid function declaration return type uint32 definition Oid #2027

MironAtHome opened this issue Aug 8, 2024 · 4 comments · Fixed by #2039
Labels
bug Something isn't working

Comments

@MironAtHome
Copy link

MironAtHome commented Aug 8, 2024

Describe the bug
A clear and concise description of what the bug is.
Code bug.
Different declaration and definition of the function return parameter type

How are you accessing AGE (Command line, driver, etc.)?
N/A

What data setup do we need to do?
N/A

What is the necessary configuration info needed?
N/A

What is the command that caused the error?
N/A

Expected behavior
N/A

Environment (please complete the following information):
branches checked, master and PG16

Additional context
Files, using GitHub UI for branch master as following
https://github.com/apache/age/blob/master/src/include/catalog/ag_graph.h
line #40
https://github.com/apache/age/blob/master/src/backend/catalog/ag_graph.c
line #143

@MironAtHome MironAtHome added the bug Something isn't working label Aug 8, 2024
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
… uint32 definition Oid, Make both return Oid
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
… uint32 definition Oid, Make both return Oid
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
… uint32 definition Oid, Make both return Oid
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
… uint32 definition Oid, Make both return Oid
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
get_graph_oid function declaration return type uint32 definition Oid
Make both return Oid
MironAtHome added a commit to MironAtHome/age that referenced this issue Aug 9, 2024
… uint32 definition Oid, Make both return Oid
@jrgemignani
Copy link
Contributor

@MironAtHome If you are going to change the function return type, you need to verify that all locations that call it will not have an issue with that change.

@MironAtHome
Copy link
Author

I did.
The good part is that it's only declaration that had uint32.
Function definition + all function calls ( I could find ) had return value declared as Oid.
I don't want to bias someone looking at the code as code reviewer, so read next few lines with a grain of salt.
When I looked over function calls, that is get_graph_oid function, all of the calls return to variable named graph_oid, all, save for one, where it's named "graph" and its type is declared as Oid, as well.
This is true for branches master, 12, 13, 14, 15 and 16, branch 11, for some reason, had type declared, as Oid in function declaration ( header file ).
In case I missed one or another ( and I checked a few times ), please add comment, I am happy to fix.

@jrgemignani
Copy link
Contributor

@MironAtHome Just wanted to make sure.

jrgemignani pushed a commit that referenced this issue Aug 12, 2024
get_graph_oid function declaration return type uint32 definition Oid
Make both return Oid
Copy link

This issue is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale Stale issues/PRs label Oct 12, 2024
@MuhammadTahaNaveed MuhammadTahaNaveed linked a pull request Oct 12, 2024 that will close this issue
@MuhammadTahaNaveed MuhammadTahaNaveed removed the Stale Stale issues/PRs label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants