ARTEMIS-3042 simple properties based, extensible broker image #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtully
force-pushed
the
properties_based_broker_base_image
branch
from
65ff52f to
adda78b
Compare
gtully
force-pushed
the
properties_based_broker_base_image
branch
from
adda78b to
8ee5d56
Compare
gemmellr
reviewed
Jan 25, 2023
gemmellr
reviewed
May 5, 2023
gtully
force-pushed
the
properties_based_broker_base_image
branch
7 times, most recently
from
91313c9 to
e59f954
Compare
|
externalised the base image in the fromImage property and updated to 20 for default |
gtully
force-pushed
the
properties_based_broker_base_image
branch
from
e59f954 to
76aee8f
Compare
|
@tabish121 have you some cycles to take another peek, thanks in advance? |
I've been looking at it and following through the docs and so far haven't stumbled on anything, looks good. |
gemmellr
reviewed
May 19, 2023
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/embedded/Main.java
Show resolved
Hide resolved
gemmellr
reviewed
May 19, 2023
gtully
force-pushed
the
properties_based_broker_base_image
branch
2 times, most recently
from
f159d9a to
6b1b7f8
Compare
gtully
force-pushed
the
properties_based_broker_base_image
branch
from
6b1b7f8 to
8684c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module builds an OCI image tar, based around a broker Main class, that can be configured with property files and/or xml.
The intent is to be a simple as possible but still be useful. See the README.md for details.