Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

test: be more lenient on jsx/tsx test coverage #468

Merged
merged 1 commit into from
May 12, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented May 8, 2020

React modules don't have to have 100% unit-test coverages.

🏆 Enhancements

🏠 Internal

@ktmud ktmud requested a review from a team as a code owner May 8, 2020 07:28
@vercel
Copy link

vercel bot commented May 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/gcq8ntdos
✅ Preview: https://superset-ui-git-fork-ktmud-codecov.superset.now.sh

@ktmud
Copy link
Contributor Author

ktmud commented May 8, 2020

Kind of feel maybe we should just get rid of the patch check?

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #468 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   22.25%   22.36%   +0.11%     
==========================================
  Files         265      266       +1     
  Lines        6521     6549      +28     
  Branches      591      605      +14     
==========================================
+ Hits         1451     1465      +14     
- Misses       5033     5047      +14     
  Partials       37       37              
Impacted Files Coverage Δ
plugins/preset-chart-xy/src/BoxPlot/index.ts 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-rose/src/index.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-sankey/src/index.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-treemap/src/index.js 0.00% <0.00%> (ø)
packages/superset-ui-translation/src/Translator.ts 100.00% <0.00%> (ø)
plugins/legacy-plugin-chart-world-map/src/index.js 0.00% <0.00%> (ø)
...lugins/plugin-chart-word-cloud/src/plugin/index.ts 33.33% <0.00%> (ø)
...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-pivot-table/src/index.js 0.00% <0.00%> (ø)
...ugins/preset-chart-xy/src/components/Line/Line.tsx 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0483db6...1057900. Read the comment docs.

codecov.yml Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
@kristw kristw changed the title build: be more lenient on jsx/tsx test cocverage build: be more lenient on jsx/tsx test coverage May 8, 2020
codecov.yml Outdated
- packages
- packages/**/*.{js|ts}$
core-packages-tsx:
target: 10%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% ?

Could we combine the core-packages-ts and core-packages-tsx section then add the ignore path for control-utils's {t|j}sx?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not 100% since relaxing this constraint on {j|t}sx is the point. That said, the number can be negotiated/adjusted at any point. 50%? ¯\_(ツ)_/¯

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ktmud ktmud changed the title build: be more lenient on jsx/tsx test coverage test: be more lenient on jsx/tsx test coverage May 8, 2020
@kristw
Copy link
Contributor

kristw commented May 8, 2020

Not sure why

image

React modules don't have to have 100% unit-test coverages.
@ktmud
Copy link
Contributor Author

ktmud commented May 9, 2020

Not sure why

image

Apparently you can't mix the use of "**" and "$". So projects/**/*.ts$ doesn't work, but projects/**/*.ts does.

@rusackas
Copy link
Member

@kristw @ktmud Seems like this is good to go, right? My trigger finger is itchy here, as this will unblock this PR.

@ktmud ktmud merged commit 42fe5a3 into apache-superset:master May 12, 2020
@ktmud ktmud deleted the codecov branch May 12, 2020 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants