-
Notifications
You must be signed in to change notification settings - Fork 271
fix: rolling and cum operator in multiple series chart #1386
fix: rolling and cum operator in multiple series chart #1386
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/ACUSShdiPhDGegDuz6J1m6yU5hXZ |
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
=======================================
Coverage 30.34% 30.35%
=======================================
Files 497 497
Lines 9979 9983 +4
Branches 1680 1681 +1
=======================================
+ Hits 3028 3030 +2
- Misses 6706 6707 +1
- Partials 245 246 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One minor improvement proposal if you have the time: it would be nice to set |
This is necessary. I will create a separate PR. |
🐛 Bug Fix
Currently, Rolling Window calculation results are incorrect on multiple series.
Backendcode at: apache/superset#16945