-
Notifications
You must be signed in to change notification settings - Fork 272
refactor(core): move mexp from plugins to core #1371
refactor(core): move mexp from plugins to core #1371
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/F88DKYqTfMUaXG3NryzGYxsqcaLK |
cf524e2
to
bc0be26
Compare
bc0be26
to
c9e0592
Compare
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 30.35% 30.49% +0.13%
==========================================
Files 495 496 +1
Lines 9897 9914 +17
Branches 1666 1666
==========================================
+ Hits 3004 3023 +19
+ Misses 6649 6647 -2
Partials 244 244
Continue to review full report at Codecov.
|
c9e0592
to
b26bc2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for jest style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the new tests!
really cool improvements! |
b26bc2e
to
5580f99
Compare
🏠 Internal
Move
math-expression-evaluator
from plugins tosuperset-ui-core
and add new functionality + tests to establish feature parity with relevantmathjs
functionality.