Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

refactor(core): move mexp from plugins to core #1371

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

villebro
Copy link
Contributor

🏠 Internal

Move math-expression-evaluator from plugins to superset-ui-core and add new functionality + tests to establish feature parity with relevant mathjs functionality.

@villebro villebro requested a review from a team as a code owner September 21, 2021 10:12
@vercel
Copy link

vercel bot commented Sep 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/F88DKYqTfMUaXG3NryzGYxsqcaLK
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-mexpr-util-superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1371 (5580f99) into master (4601f6e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
+ Coverage   30.35%   30.49%   +0.13%     
==========================================
  Files         495      496       +1     
  Lines        9897     9914      +17     
  Branches     1666     1666              
==========================================
+ Hits         3004     3023      +19     
+ Misses       6649     6647       -2     
  Partials      244      244              
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 44.44% <ø> (ø)
...ugins/plugin-chart-echarts/src/utils/annotation.ts 82.50% <ø> (-1.23%) ⬇️
...ages/superset-ui-core/src/math-expression/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4601f6e...5580f99. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review September 22, 2021 03:49
Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for jest style

Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the new tests!

@ktmud
Copy link
Contributor

ktmud commented Sep 23, 2021

really cool improvements!

@villebro villebro merged commit eae9acd into apache-superset:master Sep 23, 2021
@villebro villebro deleted the villebro/mexpr-util branch September 23, 2021 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants