-
Notifications
You must be signed in to change notification settings - Fork 272
feat(core): add support for adhoc columns #1342
feat(core): add support for adhoc columns #1342
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/Edr9PDYejhHJY8GBbgrbyAUzsu6X |
d75a5e5
to
e04427f
Compare
e04427f
to
03c92dd
Compare
03c92dd
to
3742cd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 30.81% 30.91% +0.10%
==========================================
Files 499 503 +4
Lines 10193 10215 +22
Branches 1760 1761 +1
==========================================
+ Hits 3141 3158 +17
- Misses 6800 6805 +5
Partials 252 252
Continue to review full report at Codecov.
|
3742cd6
to
6e6023b
Compare
6e6023b
to
749898c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, can't wait to see the whole feature working!
1311a96
to
e076afd
Compare
7408789
to
846b5aa
Compare
@villebro it sounds great, can you add a video to demo the. change though? |
598bed1
to
60af284
Compare
🏆 Enhancements
Add new type
AdhocColumn
that can be used as a dimension similar to howAdhocMetric
can be used as a (non-saved) metric in query requests.