Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(plugin-chart-echarts): bump to ECharts 5.2.0 #1340

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Sep 1, 2021

🏆 Enhancements

Upgrade to latest version of ECharts. Includes many new features and bugfixes, and addresses one cosmetic issue related to gauge chart.

AFTER

Now Gauge chart defaults to showing the pointer below the text:
image

BEFORE

Previously the text fell below the pointer:
image

@villebro villebro requested a review from a team as a code owner September 1, 2021 06:23
@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FFLFn1jn9rdpreWFNMvRizSEUTcJ
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-echarts-520-superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1340 (9e3c62b) into master (a415c41) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1340   +/-   ##
=======================================
  Coverage   30.02%   30.03%           
=======================================
  Files         488      488           
  Lines        9849     9850    +1     
  Branches     1651     1650    -1     
=======================================
+ Hits         2957     2958    +1     
  Misses       6653     6653           
  Partials      239      239           
Impacted Files Coverage Δ
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 83.33% <ø> (ø)
packages/superset-ui-core/src/color/ColorScheme.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a415c41...9e3c62b. Read the comment docs.

@stephenLYZ
Copy link
Contributor

LGTM!

@villebro villebro merged commit 30f59e2 into apache-superset:master Sep 3, 2021
@villebro villebro deleted the villebro/echarts-5.2.0 branch September 3, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants