This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): fix tooltip format in mixed ts chart #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Currently the Mixed Timeseries chart doesn't consider the secondary axis formatter when rendering the tooltip.
BEFORE
Despite "girls" referencing the secondary axis (right) that applies a different formatter than the primary axis (left), the secondary axis format isn't applied in the tooltip (now displays "658k", should be "657586"):
AFTER
Now the tooltip format is set based on the format defined for the axis.
Fixes apache/superset#14943