This repository was archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): add series deduplication #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2y5zECRvTYrrJ8HN1cuvWqtgRxV3 |
villebro
force-pushed
the
villebro/echarts-dedup
branch
from
cec856b to
8fda407
Compare
villebro
force-pushed
the
villebro/echarts-dedup
branch
from
8fda407 to
b32e52d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 28.04% 28.09% +0.05%
==========================================
Files 435 435
Lines 8880 8892 +12
Branches 1349 1353 +4
==========================================
+ Hits 2490 2498 +8
- Misses 6204 6207 +3
- Partials 186 187 +1
Continue to review full report at Codecov.
|
zhaoyongjie
reviewed
Apr 8, 2021
|
Thank you for this fix, tested in my local env.
|
8 tasks
NejcZdovc
pushed a commit
to blotoutio/superset-ui
that referenced
this pull request
Apr 20, 2021
…1046) * fix(plugin-chart-echarts): add series deduplication * refactor function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
If an annotation layer has a series name that already exists in the chart, the chart raises an error. This PR adds series name deduplication to ensure the chart can be drawn.
AFTER
BEFORE