This repository was archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): default to standard x-axis format #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/AM4Scg19Vz9gTJkRJFn9JxNgi2Wf |
villebro
force-pushed
the
villebro/echarts-xaxis
branch
from
eb80cdb to
a370d5f
Compare
villebro
commented
Apr 7, 2021
| ['%d-%m-%Y %H:%M:%S', '%Y-%m-%d %H:%M:%S | 14-01-2019 01:32:10'], | ||
| ['%d-%m-%Y %H:%M:%S', '%d-%m-%Y %H:%M:%S | 14-01-2019 01:32:10'], |
There was a problem hiding this comment.
Bycatch - typo in the description
villebro
force-pushed
the
villebro/echarts-xaxis
branch
from
a370d5f to
dcedf7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
+ Coverage 27.74% 28.06% +0.31%
==========================================
Files 428 436 +8
Lines 8758 8869 +111
Branches 1314 1345 +31
==========================================
+ Hits 2430 2489 +59
- Misses 6155 6194 +39
- Partials 173 186 +13
Continue to review full report at Codecov.
|
zhaoyongjie
reviewed
Apr 8, 2021
| @@ -184,7 +193,7 @@ export default function transformProps(chartProps: ChartProps): EchartsProps { | |||
| const value: number = !richTooltip ? params.value : params[0].value[0]; | |||
| const prophetValue = !richTooltip ? [params] : params; | |||
|
|
|||
| const rows: Array<string> = [`${xAxisFormatter(value)}`]; | |||
| const rows: Array<string> = [`${tooltipFormatter(value)}`]; | |||
There was a problem hiding this comment.
I tested and found that the String constructor did not work.
zhaoyongjie
approved these changes
Apr 9, 2021
8 tasks
NejcZdovc
pushed a commit
to blotoutio/superset-ui
that referenced
this pull request
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Default to using the default time axis formatter for the ECharts Timeseries chart and remove default 45 degree rotation. Also introduce a new adaptive time formatter for use in the tooltip which shows increasing level of detail based on the timestamp. This is in contrast with the current adaptive time formatter, which e.g. only shows the seconds/milliseconds when a timestamp has second/subsecond granularity.
Last full year (only months show up):
Last quarter (months with weekly ticks):
Last month (four day ticks):
Last week (daily ticks):
Two days (6 hour ticks):
Tooltip with millisecond granularity data:
