-
Notifications
You must be signed in to change notification settings - Fork 272
feat(plugin-chart-table): enable emitting cross-filters #1041
feat(plugin-chart-table): enable emitting cross-filters #1041
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/4ccueFk7G88KxmjYPyiV4vUGxmui |
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
+ Coverage 27.65% 28.05% +0.39%
==========================================
Files 428 435 +7
Lines 8797 8882 +85
Branches 1335 1350 +15
==========================================
+ Hits 2433 2492 +59
- Misses 6183 6204 +21
- Partials 181 186 +5
Continue to review full report at Codecov.
|
setDataMask({ | ||
crossFilters: { | ||
extraFormData: { | ||
append_form_data: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether there is room for a simpler public API to set cross filters. Now It feels a little tedious that every chart with corss-filter support has to set this very long nested object themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually currently cleaning up the API (some of this is leftovers from during development when it wasn't clear in which direction this was going to ultimately go)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works like a charm!
…set#1041) * feat(plugin-chart-table): enable emitting cross-filters * Hide filters checkbox when cross filters flag is disabled
This PR enables emitting cross-filters from Table chart.
To enable the feature, set the feature flag
DASHBOARD_CROSS_FILTERS
insuperset/config.py
and select "ENABLE EMITTING FILTERS" checkbox in Customize tab.To select filter values, click on cells in groupby columns. Selecting a value emits a filter with an
IN
operator.https://user-images.githubusercontent.com/15073128/113731815-5c084100-96f9-11eb-92c5-bdfb969ae9e9.mov

CC @junlincc @villebro @ktmud