Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-echarts): emit filter events when clicking on pie slice #1009

Closed

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Mar 16, 2021

🏆 Enhancements
Add cross filtering to Pie Chart.
pie-filter

TODO:

  • add checkbox to control panel to enable/disable emitting filters (default to disabled)
  • add multiselect functionality
  • add option to clear selection (button in corner?)

@villebro villebro requested a review from a team as a code owner March 16, 2021 09:30
@vercel
Copy link

vercel bot commented Mar 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2zjLqMQLVvyhozaECyYkFE6hktQM
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-pie-filter-superset.vercel.app

@villebro villebro force-pushed the villebro/pie-filter branch from 7cbd63d to de2c642 Compare March 16, 2021 09:39
@villebro villebro changed the title [WIP] feat(plugin-chart-echarts): emit filter events when clicking on slice [WIP] feat(plugin-chart-echarts): emit filter events when clicking on pie slice Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1009 (a5dd474) into master (de89466) will decrease coverage by 0.00%.
The diff coverage is 25.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   27.95%   27.94%   -0.01%     
==========================================
  Files         414      414              
  Lines        8535     8563      +28     
  Branches     1218     1224       +6     
==========================================
+ Hits         2386     2393       +7     
- Misses       5992     6013      +21     
  Partials      157      157              
Impacted Files Coverage Δ
...lugins/plugin-chart-echarts/src/Pie/EchartsPie.tsx 0.00% <0.00%> (ø)
plugins/plugin-chart-echarts/src/Pie/index.ts 0.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Pie/types.ts 100.00% <ø> (ø)
...ins/plugin-chart-echarts/src/components/Echart.tsx 0.00% <0.00%> (ø)
plugins/plugin-chart-echarts/src/types.ts 100.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 74.41% <100.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de89466...a5dd474. Read the comment docs.

@junlincc
Copy link
Contributor

junlincc commented Mar 16, 2021

@villebro we decided to use the tree scoping modal as design for this stage which support multi-select.
i do agree we should have a shortcut to disable the scoped relationship from dashboard directly.

@mihir please chime in 🙏

@villebro villebro changed the title [WIP] feat(plugin-chart-echarts): emit filter events when clicking on pie slice feat(plugin-chart-echarts): emit filter events when clicking on pie slice Mar 18, 2021
@villebro villebro closed this Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants