This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
feat(plugin-chart-echarts): emit filter events when clicking on pie slice #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2zjLqMQLVvyhozaECyYkFE6hktQM |
villebro
force-pushed
the
villebro/pie-filter
branch
from
March 16, 2021 09:39
7cbd63d
to
de2c642
Compare
villebro
changed the title
[WIP] feat(plugin-chart-echarts): emit filter events when clicking on slice
[WIP] feat(plugin-chart-echarts): emit filter events when clicking on pie slice
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 27.95% 27.94% -0.01%
==========================================
Files 414 414
Lines 8535 8563 +28
Branches 1218 1224 +6
==========================================
+ Hits 2386 2393 +7
- Misses 5992 6013 +21
Partials 157 157
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/pie-filter
branch
from
March 16, 2021 11:10
e19e500
to
5a6ad56
Compare
simcha90
reviewed
Mar 17, 2021
simcha90
reviewed
Mar 17, 2021
villebro
changed the title
[WIP] feat(plugin-chart-echarts): emit filter events when clicking on pie slice
feat(plugin-chart-echarts): emit filter events when clicking on pie slice
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Add cross filtering to Pie Chart.
TODO: