fix: heatmap errors with null data

apache-superset · Jun 26, 2019 · d773983 · d773983
1 parent ca591ec
commit d773983
Show file tree

Hide file tree

Showing 2 changed files with 209 additions and 160 deletions.
diff --git a/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-heatmap/src/Heatmap.js b/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-heatmap/src/Heatmap.js
@@ -109,8 +109,8 @@ function Heatmap(element, props) {
 
     for (let i = 0; i < records.length; i++) {
       const datum = records[i];
-      longestX = Math.max(longestX, datum.x.toString().length || 1);
-      longestY = Math.max(longestY, datum.y.toString().length || 1);
+      longestX = Math.max(longestX, (datum.x && datum.x.toString().length) || 1);
+      longestY = Math.max(longestY, (datum.y && datum.y.toString().length) || 1);
     }
 
     if (leftMargin === 'auto') {