feat(plugin-chart-word-cloud): allow minimum size (#487)

* feat(plugin-chart-word-cloud): allow minimum size * fix: type * fix: test
apache-superset · May 13, 2020 · 356229b · 356229b · vercel · May 13, 2020
1 parent 9b6d611
commit 356229b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/plugins/plugin-chart-word-cloud/src/legacyPlugin/transformProps.ts b/plugins/plugin-chart-word-cloud/src/legacyPlugin/transformProps.ts
@@ -16,7 +16,14 @@ function getMetricLabel(metric: LegacyWordCloudFormData['metric']): string | und
 
 export default function transformProps(chartProps: ChartProps): WordCloudProps {
   const { width, height, formData, queryData } = chartProps;
-  const { colorScheme, metric, rotation, series, sizeTo } = formData as LegacyWordCloudFormData;
+  const {
+    colorScheme,
+    metric,
+    rotation,
+    series,
+    sizeFrom = 0,
+    sizeTo,
+  } = formData as LegacyWordCloudFormData;
 
   const metricLabel = getMetricLabel(metric);
 
@@ -34,7 +41,7 @@ export default function transformProps(chartProps: ChartProps): WordCloudProps {
         : {
             field: metricLabel,
             scale: {
-              range: [0, sizeTo],
+              range: [sizeFrom, sizeTo],
               zero: true,
             },
             type: 'quantitative',

diff --git a/plugins/plugin-chart-word-cloud/src/legacyPlugin/types.ts b/plugins/plugin-chart-word-cloud/src/legacyPlugin/types.ts
@@ -5,5 +5,6 @@ export type LegacyWordCloudFormData = QueryFormData & {
   colorScheme: string;
   rotation?: RotationType;
   series: string;
+  sizeFrom?: number;
   sizeTo: number;
 };
diff --git a/plugins/plugin-chart-word-cloud/test/legacyPlugin/transformProps.test.ts b/plugins/plugin-chart-word-cloud/test/legacyPlugin/transformProps.test.ts
@@ -37,7 +37,7 @@ describe('WordCloud tranformProps', () => {
         fontSize: {
           field: 'sum__num',
           scale: {
-            range: [0, 70],
+            range: [10, 70],
             zero: true,
           },
           type: 'quantitative',