Skip to content

Commit

Permalink
fix: Remove framework assembly references from Grynwald.MdDocs.MSBuil…
Browse files Browse the repository at this point in the history
…d NuGet package

Remove redundant framework assembly references since the Grynwald.MdDocs.MSBuild package is a build tools package which does not require references to .NET Framework assemblies to be added to consuming projects.

Pull-Request: #234
  • Loading branch information
ap0llo authored Jan 1, 2023
1 parent 8eb6634 commit 14d8c73
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,7 @@
IsDevelopmentDependency: true,
PackageTypes: [],
Dependencies: [],
FrameworkReferences: [
{
TargetFramework: .NETFramework,Version=v4.7.2,
Assemblies: [
System.IO,
System.Runtime,
System.Security.Cryptography.Algorithms,
System.Security.Cryptography.Encoding,
System.Security.Cryptography.Primitives
]
}
],
FrameworkReferences: [],
Files: [
build/net472/Grynwald.MdDocs.MSBuild.pdb,
build/netstandard2.0/Grynwald.MdDocs.MSBuild.pdb,
Expand Down
11 changes: 10 additions & 1 deletion src/MdDocs.MSBuild/Grynwald.MdDocs.MSBuild.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ProjectReference Include="..\MdDocs.CommandLineHelp\Grynwald.MdDocs.CommandLineHelp.csproj" />
<ProjectReference Include="..\MdDocs.Common\Grynwald.MdDocs.Common.csproj" />
</ItemGroup>

<!-- Adjust NuGet package properties -->
<PropertyGroup>
<Description>MdDocs is a tool generate documentation as markdown files. This package integrates the generation of documentation into the build process.</Description>
Expand Down Expand Up @@ -50,5 +50,14 @@
</ItemGroup>
</Target>

<!-- Remove framework references from the output NuGet package (not required for a build tools package)-->
<PropertyGroup>
<GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);RemoveFrameworkAssemblyReferences</GenerateNuspecDependsOn>
</PropertyGroup>
<Target Name="RemoveFrameworkAssemblyReferences">
<ItemGroup>
<_FrameworkAssemblyReferences Remove="@(_FrameworkAssemblyReferences)" />
</ItemGroup>
</Target>

</Project>

0 comments on commit 14d8c73

Please sign in to comment.