Make the lib configurable and feed the output #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like your work. Let me test it a bit before merge. |
|
Thank you! Do not hesitate if you want me to make changes. This PR is important in order to use the official NPM package for https://github.com/yannickglt/karma-lintspell. |
aotaduy
added a commit
that referenced
this pull request
Jan 5, 2016
Make the lib configurable and feed the output
|
Merged ! tonight i will publish the updated package. Thank you ! |
|
Great! Thank you. |
|
I have publsihed the updated package to npm thanks for the Pull Request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to give options to the checker. For example, the
skipWordsoption will allow each project usinglintspelljsas NPM dependency to add their own dictionary.Feeding the output with the success messages will allow making statistics on the rate of the failing words for example. The
wordentry is useful to determine what words should be added to the skipWords.