Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement spell check in separated by underscore words #83

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

stu01509
Copy link
Contributor

@stu01509 stu01509 commented Nov 9, 2022

Describe

Hello @aotaduy

According to this PR, I implemented the underscoreParser function to check the uppercase word separated by an underscore, hoping you could take some time to review and release the new version to npm.

Changes

  • Add new config ignoreUpperCaseUnderscore description in the README.md file.
  • Implemented the underscoreParser function in the rules/spell-checker.js file.
  • Add some unit tests in the test/spell-checker.js file.

rules/spell-checker.js Outdated Show resolved Hide resolved
@aotaduy
Copy link
Owner

aotaduy commented Nov 17, 2022

Hi Thanks foir the pull request !
Is this change retro compatible ?
I mean if you dont configure anything, the plugin will behave as before this changes?

Let me test this locally

@aotaduy
Copy link
Owner

aotaduy commented Nov 17, 2022

I think right now we are ignoring variables in uppercase with underscores, so te be retrocompatible we might need to set the configuration to true in order to not break projects that are actually using this plugin.

README.md Outdated Show resolved Hide resolved
@stu01509 stu01509 force-pushed the feat/check-uppercase-underscore branch from 8842bc7 to a66132a Compare November 18, 2022 15:45
@stu01509 stu01509 force-pushed the feat/check-uppercase-underscore branch from a66132a to 3ee411e Compare November 18, 2022 15:47
@stu01509
Copy link
Contributor Author

Hi @aotaduy

Thanks for your reviews, I've updated some changes below:

  • Rename config ignoreUpperCaseUnderscore to enableUpperCaseUnderscoreCheck.
  • Adjust underscoreParser() function condition logic.
  • Add more unit tests to cover those scenarios.

Kindly Review :)

@aotaduy
Copy link
Owner

aotaduy commented Nov 18, 2022

Looks good !

@stu01509
Copy link
Contributor Author

Thanks for your review, hope you could merge and release the new version to npm.

@aotaduy aotaduy merged commit 17e13f8 into aotaduy:master Nov 22, 2022
@aotaduy
Copy link
Owner

aotaduy commented Nov 22, 2022

@stu01509 the changes are published un npm as a new release.
thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants