-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement spell check in separated by underscore words #83
feat: implement spell check in separated by underscore words #83
Conversation
Hi Thanks foir the pull request ! Let me test this locally |
I think right now we are ignoring variables in uppercase with underscores, so te be retrocompatible we might need to set the configuration to true in order to not break projects that are actually using this plugin. |
8842bc7
to
a66132a
Compare
a66132a
to
3ee411e
Compare
Hi @aotaduy Thanks for your reviews, I've updated some changes below:
Kindly Review :) |
Looks good ! |
Thanks for your review, hope you could merge and release the new version to npm. |
@stu01509 the changes are published un npm as a new release. |
Describe
Hello @aotaduy
According to this PR, I implemented the
underscoreParser
function to check the uppercase word separated by an underscore, hoping you could take some time to review and release the new version to npm.Changes
ignoreUpperCaseUnderscore
description in theREADME.md
file.underscoreParser
function in therules/spell-checker.js
file.test/spell-checker.js
file.