Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizacion del server: agregamos nuevos ID para msg al cliente #668

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ReyarB
Copy link
Contributor

@ReyarB ReyarB commented Dec 9, 2024

Primeros mensajes pasados a ID

Update modHechizos.bas

@ReyarB ReyarB requested review from RecoX and morgolock December 9, 2024 10:00
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@ReyarB ReyarB force-pushed the Paso-de-MSG-a-ID-para-el-cliente branch from 1b0d249 to f838535 Compare December 9, 2024 13:40
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@ReyarB ReyarB force-pushed the Paso-de-MSG-a-ID-para-el-cliente branch from d49c164 to 916300b Compare December 9, 2024 19:15
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@adrianbielsa1 adrianbielsa1 self-assigned this Dec 9, 2024
@morgolock morgolock changed the title Nuevos ID para msg al cliente Localizacion del server: agregamos nuevos ID para msg al cliente en vez de enviar strings Dec 9, 2024
@morgolock morgolock changed the title Localizacion del server: agregamos nuevos ID para msg al cliente en vez de enviar strings Localizacion: server envia ID de mensaje en vez de strings Dec 9, 2024
@adrianbielsa1
Copy link
Collaborator

@morgolock tenía planeado sugerir unos cambios. Si se puede esperar a mergear el PR hasta entonces, mejor.

@RecoX
Copy link
Member

RecoX commented Dec 9, 2024

@morgolock tenía planeado sugerir unos cambios. Si se puede esperar a mergear el PR hasta entonces, mejor.

Estaria buenisimo mejorar el sistema, aunque ahora mismo solo se estan removiendo los mensajes "HARCODEADOS" y poniendolos en el archivo localindex.dat

Esto ya funciona asi desde hace mucho, pero si estaria bueno poder mejorar este sistema ya que obtener los mensajes por ID es poco claro

@morgolock
Copy link
Contributor

@morgolock tenía planeado sugerir unos cambios. Si se puede esperar a mergear el PR hasta entonces, mejor.

@adrianbielsa1 @RecoX No hay problema,

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@ReyarB ReyarB force-pushed the Paso-de-MSG-a-ID-para-el-cliente branch from 03ac503 to 793d646 Compare December 9, 2024 22:53
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@ReyarB ReyarB changed the title Localizacion: server envia ID de mensaje en vez de strings Localizacion del server: agregamos nuevos ID para msg al cliente Dec 9, 2024
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@ReyarB ReyarB force-pushed the Paso-de-MSG-a-ID-para-el-cliente branch from 161f802 to 90a15d7 Compare December 10, 2024 02:28
@ReyarB ReyarB requested a review from adrianbielsa1 December 10, 2024 09:59
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Sumo ID que ya están en recursos

Id para cliente

Agrego mas ID para el server pasar al Cliente

Update Acciones.bas

Nuevos ID para msg al cliente

Primeros mensajes pasados a ID

Update modHechizos.bas

ID Nuevos Para el server

Nuevos ID del server

Code formatter en Trabajo.bas

Agrego ID del 693 al 735

Id Hasta el 776

Agrego ID para el cliente
@ReyarB ReyarB force-pushed the Paso-de-MSG-a-ID-para-el-cliente branch from e791893 to 9cabb20 Compare December 10, 2024 16:25
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@RecoX RecoX merged commit ef06802 into master Dec 10, 2024
1 check passed
@RecoX RecoX deleted the Paso-de-MSG-a-ID-para-el-cliente branch December 10, 2024 19:54
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants