Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted Persistance of Character's inventory #662

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Reverted Persistance of Character's inventory #662

merged 1 commit into from
Nov 28, 2024

Conversation

RecoX
Copy link
Member

@RecoX RecoX commented Nov 28, 2024

This pull request includes a significant change to the SaveCharacterDB method in the Codigo/CharacterPersistence.bas file. The change simplifies the inventory slot handling by removing the conditional logic based on user type and directly using a fixed maximum inventory slot limit.

Simplification of inventory slot handling:

  • Removed conditional logic that determined inventory slot limits based on user type (tLeyenda, tHeroe, etc.) and replaced it with a fixed maximum inventory slot limit (MAX_INVENTORY_SLOTS).
  • Adjusted the loop to iterate over the fixed maximum inventory slots and updated the parameters accordingly.

NOTE: This will delete all the items for subscriptions that are removed in the special inventory slots.

@RecoX RecoX merged commit 0448123 into master Nov 28, 2024
1 check passed
@RecoX RecoX deleted the iv-re branch November 28, 2024 00:38
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant