Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CharacterPersistence #660

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Improved CharacterPersistence #660

merged 2 commits into from
Nov 27, 2024

Conversation

RecoX
Copy link
Member

@RecoX RecoX commented Nov 27, 2024

This pull request includes several changes to the Codigo/CharacterPersistence.bas and Codigo/Declares.bas files to improve error handling and add functionality for different user types in the inventory system. The most important changes are listed below:

Error handling improvements:

Inventory system enhancements:

  • Codigo/CharacterPersistence.bas: Modified the LoadCharacterInventory function to determine the SQL query based on the user type (tLeyenda, tHeroe, or other) for inventory items.
  • Codigo/CharacterPersistence.bas: Updated the SaveCharacterDB function to determine the inventory slot limit based on the user type, preventing the deletion of items if a subscription is removed.
  • Codigo/Declares.bas: Added a new constant MAX_USERINVENTORY_HERO_SLOTS for hero inventory slots and updated related inventory slot constants.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

No scoreable code touched

View detailed results in CodeScene

@RecoX RecoX merged commit a297e83 into master Nov 27, 2024
2 checks passed
@RecoX RecoX deleted the iv branch November 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant