harness: Clone accounts from transaction context instead of take #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
approved these changes
Jan 15, 2025
buffalojoec
pushed a commit
that referenced
this pull request
Jan 15, 2025
buffalojoec
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When accounts are updated using the resulting accounts, accounts are taken from the
transaction_contextleaving anAccount::default()on its place. When an instruction has multiple entries of the same account, the remaining "copies" of the account is updated with a default value.Solution
Replace the use of
take()byborrow().clone(), so the correct value can be used for the remaining "copies" of the same account.