[SOL] Implement store imm instructions #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
approved these changes
Dec 2, 2024
LucasSte
merged commit a802634
into
anza-xyz:solana-rustc/18.1-2024-05-19
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMD-0173 introduces a new encoding for store immediate instructions in the SBF target. These instructions were implemented last year in the BPF target (see 8f28e80) but we never brought them to our custom backend.
This PR implements the instructions in SBF with a couple of adjustments from the original BPF commit and gates them behind a feature flag. I'll update the encoding in a follow up PR.