Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: blockstore: mark slot as dead on data shred merkle root conflict (backport of #3970) #4074

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 12, 2024

We need to mark the slot as dead to ensure that the bank is completed


This is an automatic backport of pull request #3970 done by [Mergify](https://mergify.com).

(cherry picked from commit 5564a94)

# Conflicts:
#	ledger/src/blockstore.rs
@mergify mergify bot added the conflicts label Dec 12, 2024
@mergify mergify bot requested a review from a team as a code owner December 12, 2024 00:11
Copy link
Author

mergify bot commented Dec 12, 2024

Cherry-pick of 5564a94 has failed:

On branch mergify/bp/v2.0/pr-3970
Your branch is up to date with 'origin/v2.0'.

You are currently cherry-picking commit 5564a941ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ledger/src/blockstore.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@AshwinSekar AshwinSekar requested a review from carllin December 19, 2024 19:45
@AshwinSekar AshwinSekar merged commit 843c6a1 into v2.0 Dec 20, 2024
38 checks passed
@AshwinSekar AshwinSekar deleted the mergify/bp/v2.0/pr-3970 branch December 20, 2024 03:16
nibty added a commit to x1-labs/tachyon that referenced this pull request Feb 5, 2025
* v2.0: Reclaims more old accounts in `clean` (backport of anza-xyz#4044) (anza-xyz#4089)

* Reclaims more old accounts in `clean` (anza-xyz#4044)

(cherry picked from commit 3d43824)

# Conflicts:
#	accounts-db/src/accounts_db.rs
#	accounts-db/src/accounts_db/tests.rs

* fix merge conflicts

---------

Co-authored-by: Brooks <[email protected]>

* v2.0: Fixes clean_old_storages_with_reclaims tests (backport of anza-xyz#4147) (anza-xyz#4166)

* Fixes clean_old_storages_with_reclaims tests (anza-xyz#4147)

(cherry picked from commit 4eabeed)

# Conflicts:
#	accounts-db/src/accounts_db/tests.rs

* fix merge conflicts

---------

Co-authored-by: Brooks <[email protected]>

* v2.0: blockstore: mark slot as dead on data shred merkle root conflict (backport of anza-xyz#3970) (anza-xyz#4074)

* blockstore: mark slot as dead on data shred merkle root conflict (anza-xyz#3970)

(cherry picked from commit 5564a94)

# Conflicts:
#	ledger/src/blockstore.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>

* Bump version to v2.0.22 (anza-xyz#4200)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: hardcode rust version for publish-crate (anza-xyz#4228)

* Bump version to v2.0.23 (anza-xyz#4419)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: rolls out chained Merkle shreds to ~21% of mainnet slots (backport of anza-xyz#4431) (anza-xyz#4434)

rolls out chained Merkle shreds to ~21% of mainnet slots (anza-xyz#4431)

(cherry picked from commit 9d09787)

Co-authored-by: behzad nouri <[email protected]>

* v2.0: [rpc] Fatal `getSignaturesForAddress()` when Bigtable errors (backport of anza-xyz#3700) (anza-xyz#4442)

[rpc] Fatal `getSignaturesForAddress()` when Bigtable errors (anza-xyz#3700)

* Unindent code in `get_signatures_for_address`

* Add a custom JSON-RPC error to throw when long-term storage (ie. Bigtable) can't be reached

* When the `before`/`until` signatures can't be found, throw `SignatureNotFound` instead of `RowNotFound`

* Fatal `getSignaturesForAddress` calls when Bigtable must be queried but can't be reached

(cherry picked from commit 52f132c)

Co-authored-by: Steven Luscher <[email protected]>

* v2.0: ci: bump [upload|download]-artifact to v4 (anza-xyz#4501)

ci: bump [upload|download]-artifact to v4

* v2.0: ci: hardcode crate publishing version (anza-xyz#4515)

ci: hardcode rust version for publish-crate

* Bump version to v2.0.24 (anza-xyz#4528)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: fix: reduce max packet receive time during leader window (backport of anza-xyz#2801) (anza-xyz#4544)

fix: reduce max packet receive time during leader window (anza-xyz#2801)

(cherry picked from commit 20e0df4)

Co-authored-by: cavemanloverboy <[email protected]>

* v2.0: Scheduler Frequency Fixes (backport of anza-xyz#4545) (anza-xyz#4576)

* Change prio_graph_scheduler configurations for 1k maxs, 256 look ahead

* Break loop on scanned transaction count

* make Hold decision behave same as Consume during receive

* receive maximum of 5_000 packets - loose max

* receive_completed before process_transactions

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yihau Chen <[email protected]>
Co-authored-by: behzad nouri <[email protected]>
Co-authored-by: Steven Luscher <[email protected]>
Co-authored-by: cavemanloverboy <[email protected]>
Co-authored-by: Andrew Fitzgerald <[email protected]>
nibty added a commit to x1-labs/tachyon that referenced this pull request Feb 6, 2025
* v2.0: Reclaims more old accounts in `clean` (backport of anza-xyz#4044) (anza-xyz#4089)

* Reclaims more old accounts in `clean` (anza-xyz#4044)

(cherry picked from commit 3d43824)

# Conflicts:
#	accounts-db/src/accounts_db.rs
#	accounts-db/src/accounts_db/tests.rs

* fix merge conflicts

---------

Co-authored-by: Brooks <[email protected]>

* v2.0: Fixes clean_old_storages_with_reclaims tests (backport of anza-xyz#4147) (anza-xyz#4166)

* Fixes clean_old_storages_with_reclaims tests (anza-xyz#4147)

(cherry picked from commit 4eabeed)

# Conflicts:
#	accounts-db/src/accounts_db/tests.rs

* fix merge conflicts

---------

Co-authored-by: Brooks <[email protected]>

* v2.0: blockstore: mark slot as dead on data shred merkle root conflict (backport of anza-xyz#3970) (anza-xyz#4074)

* blockstore: mark slot as dead on data shred merkle root conflict (anza-xyz#3970)

(cherry picked from commit 5564a94)

# Conflicts:
#	ledger/src/blockstore.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>

* Bump version to v2.0.22 (anza-xyz#4200)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: hardcode rust version for publish-crate (anza-xyz#4228)

* Bump version to v2.0.23 (anza-xyz#4419)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: rolls out chained Merkle shreds to ~21% of mainnet slots (backport of anza-xyz#4431) (anza-xyz#4434)

rolls out chained Merkle shreds to ~21% of mainnet slots (anza-xyz#4431)

(cherry picked from commit 9d09787)

Co-authored-by: behzad nouri <[email protected]>

* v2.0: [rpc] Fatal `getSignaturesForAddress()` when Bigtable errors (backport of anza-xyz#3700) (anza-xyz#4442)

[rpc] Fatal `getSignaturesForAddress()` when Bigtable errors (anza-xyz#3700)

* Unindent code in `get_signatures_for_address`

* Add a custom JSON-RPC error to throw when long-term storage (ie. Bigtable) can't be reached

* When the `before`/`until` signatures can't be found, throw `SignatureNotFound` instead of `RowNotFound`

* Fatal `getSignaturesForAddress` calls when Bigtable must be queried but can't be reached

(cherry picked from commit 52f132c)

Co-authored-by: Steven Luscher <[email protected]>

* v2.0: ci: bump [upload|download]-artifact to v4 (anza-xyz#4501)

ci: bump [upload|download]-artifact to v4

* v2.0: ci: hardcode crate publishing version (anza-xyz#4515)

ci: hardcode rust version for publish-crate

* Bump version to v2.0.24 (anza-xyz#4528)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* v2.0: fix: reduce max packet receive time during leader window (backport of anza-xyz#2801) (anza-xyz#4544)

fix: reduce max packet receive time during leader window (anza-xyz#2801)

(cherry picked from commit 20e0df4)

Co-authored-by: cavemanloverboy <[email protected]>

* v2.0: Scheduler Frequency Fixes (backport of anza-xyz#4545) (anza-xyz#4576)

* Change prio_graph_scheduler configurations for 1k maxs, 256 look ahead

* Break loop on scanned transaction count

* make Hold decision behave same as Consume during receive

* receive maximum of 5_000 packets - loose max

* receive_completed before process_transactions

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yihau Chen <[email protected]>
Co-authored-by: behzad nouri <[email protected]>
Co-authored-by: Steven Luscher <[email protected]>
Co-authored-by: cavemanloverboy <[email protected]>
Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants