Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrioGraphSchedulerConfig #4064

Merged
merged 4 commits into from
Dec 13, 2024
Merged

PrioGraphSchedulerConfig #4064

merged 4 commits into from
Dec 13, 2024
+63 −26

Conversation

apfitzge
Copy link

Problem

  • Various constants for prio-graph scheduler behavior are used
  • They are spread around which makes changing them harder for people who are not as familiar with the code

Summary of Changes

  • Create a PrioGraphSchedulerConfig to wrap these constants
  • Pass config to PrioGraphScheduler::new
  • schedule uses config instead of constants

Fixes #

@apfitzge apfitzge self-assigned this Dec 11, 2024
This was referenced Dec 11, 2024
Open
Open
@apfitzge apfitzge marked this pull request as ready for review December 12, 2024 23:12
@apfitzge apfitzge requested a review from tao-stones December 12, 2024 23:12
tao-stones
tao-stones approved these changes Dec 13, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 29d4b57 into anza-xyz:master Dec 13, 2024
40 checks passed
@apfitzge apfitzge deleted the scheduler_config branch December 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @tao-stones