v2.1: Memory syscalls cannot start in an account and end outside of it (backport of #3744) #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Memory syscalls cannot start in an account and end outside of it In the same way, a memory syscall cannot start outside of an account and up within one. (cherry picked from commit 36d1017)
|
The Firedancer team maintains a line-for-line reimplementation of the |
Lichtso
approved these changes
Dec 4, 2024
t-nelson
approved these changes
Dec 6, 2024
KirillLykov
pushed a commit
that referenced
this pull request
Dec 9, 2024
…t (backport of #3744) (#3885) * Memory syscalls cannot start in an account and end outside of it (#3744) * Memory syscalls cannot start in an account and end outside of it In the same way, a memory syscall cannot start outside of an account and up within one. (cherry picked from commit 36d1017) * Update Cargo.lock --------- Co-authored-by: Sean Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input area of the address space contains things like the instruction data and the accounts passed into the program, including the account data itself. From the perspective of the SBF program, all these are stored back-to-back in memory, but with direct mapping, the account data is actually stored in a separate memory region.
Previously, memcpy, memmove, memcmp, and memset can start and stop anywhere in memory; it is possible to start in account data, and give a length beyond the end of the account data; it would cross into a new region. Conversely, it possible to start before account data and up within the account data.
This change restricts these four syscalls so that memory regions are entirely inside account data or outside of it.
There is no reason why you require this and no mainnet program does this. This change was requested by Firedancer for direct mapping.
This is part of the stricter VM verfication SIMD which is required for direct mapping.
This is an automatic backport of pull request #3744 done by [Mergify](https://mergify.com).