v2.1: Make unified-scheduler use transaction_status_sender in ledger-tool (backport of #3861) #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
ryoqun
force-pushed
the
mergify/bp/v2.1/pr-3861
branch
from
3736eaa
to
0796662
Compare
apfitzge
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some functionalities (
--enable-rpc-transaction-historyand--record-slots-config=tx) ofagave-ledger-tool verifyis broken ifunified-scheduleris active asblock-verification-method.Notably, I'd propose to bp this pr to both v2.0 and v2.1, because
agave-ledger-tool's--enable-rpc-transaction-historyand--enable-extended-tx-metadata-storageare kind of important functionalities for ops.as for v2.0,
unified-schedulerwon't be active unless explicitly enabled via CLI flags. On the other hand, it will be active by default for v2.1. So, bp to v2.1 is kind of a must. bp to v2.0 is desired for consistency.Summary of Changes
Fit it by plumbing properly the
transaction_status_sender....This is an automatic backport of pull request #3861 done by [Mergify](https://mergify.com).